-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/
-----------------------------------------------------------
(Updated Dec. 14, 2016, 9:52 a.m.)
Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
Changes
-------
made it compliant with 3066 + fixed per reviews
Bugs: SQOOP-3081
https://issues.apache.org/jira/browse/SQOOP-3081
Repository: sqoop-trunk
Description
-------
SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In
OracleUpsertOutputFormat to make it consistent with the rest of the code and
add escaping to the rest of the column variables.
Diffs (updated)
-----
src/java/org/apache/sqoop/SqoopOptions.java 53cc03a
src/java/org/apache/sqoop/manager/oracle/OracleUtils.java aa56e70
src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7
src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92
Diff: https://reviews.apache.org/r/54699/diff/
Testing
-------
ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib
-Dthirdparty=true
-Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
-Dtest.timeout=1000000 -Dtestcase=*racle*Test with special attention to
OracleExportTest#testUpsertTextExport
Thanks,
Anna Szonyi
