[ https://issues.apache.org/jira/browse/SQOOP-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770396#comment-15770396 ]
Boglarka Egyed edited comment on SQOOP-3090 at 12/22/16 4:08 PM: ----------------------------------------------------------------- Hey [~maugli], Many thanks for your comments, I really appreciate it! I have created two sub-tasks for two test class sets separated by their container packages. Thanks, Bogi was (Author: boglarkaegyed): Hey [~maugli], Many thanks for your comments, I really appreciate it! I have created created two sub-tasks for two test class sets separated by their container packages. Thanks, Bogi > Normalize test cases where expect an exception > ---------------------------------------------- > > Key: SQOOP-3090 > URL: https://issues.apache.org/jira/browse/SQOOP-3090 > Project: Sqoop > Issue Type: Improvement > Affects Versions: 1.4.6 > Reporter: Boglarka Egyed > Assignee: Boglarka Egyed > Priority: Minor > > Many test cases uses the following logic to test if an exception has been > thrown: > {code:java} > try { > <do something> > fail("Expected exception"); > } catch (someException e) { > // expected > } > } > {code} > This form is not self-explanatory enough and could be replaced by a one line > ExpectedException check which would be more clean. -- This message was sent by Atlassian JIRA (v6.3.4#6332)