----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/#review164793 -----------------------------------------------------------
src/java/org/apache/sqoop/manager/Db2Manager.java (line 176) <https://reviews.apache.org/r/55132/#comment236570> Is this a Hive specific type? Or a Java specific type? src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java (line 190) <https://reviews.apache.org/r/55132/#comment236574> Why not just use a static string or static array of strings? src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java (line 215) <https://reviews.apache.org/r/55132/#comment236575> You could just move the contents of this method into the test case method above src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java (lines 218 - 220) <https://reviews.apache.org/r/55132/#comment236578> Is this necessary? - Abraham Elmahrek On Feb. 6, 2017, 3:19 a.m., Ying Cao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55132/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 3:19 a.m.) > > > Review request for Sqoop, Abraham Elmahrek and Jarek Cecho. > > > Bugs: SQOOP-1904 > https://issues.apache.org/jira/browse/SQOOP-1904 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-1904: support for DB2 XML data type when importing to hdfs > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/Db2Manager.java e39aa4c > src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/55132/diff/ > > > Testing > ------- > > UT passed by manually > > > Thanks, > > Ying Cao > >
