----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55259/#review170372 -----------------------------------------------------------
Hi Hu, Thank you for your contribution, it seems completely reasonable since the lowerBound and upperBound parameters are always casted to BigDecimal. I wonder why this problem was not discovered before I guess this part of the code is not covered with test cases. Can you please add a unit test which proves that your solution works now? Thanks, Szabolcs - Szabolcs Vasas On March 29, 2017, 6:43 a.m., hu xiaodong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55259/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 6:43 a.m.) > > > Review request for Sqoop, Andrew Bayer, Abraham Elmahrek, Ahmed Radwan, and > Jarek Cecho. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > https://issues.apache.org/jira/browse/SQOOP-3008 > > GenericJdbcPartitioner.constructTextConditions(String, Object, Object, > String, String, boolean, boolean) may occur java.lang.ClassCastException > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java > 77b486c > > > Diff: https://reviews.apache.org/r/55259/diff/1/ > > > Testing > ------- > > > Thanks, > > hu xiaodong > >
