> On Mag. 16, 2017, 3:59 p.m., Szabolcs Vasas wrote: > > Hi Michele, > > > > The change seems correct to me since these tables are used in a query in > > org.apache.sqoop.manager.oracle.OraOopOracleQueries#getOracleDataChunksPartition > > method which is used from > > org.apache.sqoop.manager.oracle.OraOopDataDrivenDBInputFormat#getSplits > > which runs during an import. > > > > Regards, > > Szabolcs > > Michele Milesi wrote: > Hi Szabolcs > I've crawled the source code before configure our Oracle :) > > BTW it's my first patch for Sqoop, I've to close/submit it now? Or I've > to await more +1? > > Thanks and regards > Michele > > Szabolcs Vasas wrote: > Your patch should be reviewed by a committer too who will put your change > in trunk. You can add Anna Szonyi or Attila Szabo to this review they are > pretty active committers. > > Szabolcs
Thanks Szabolcs Michele - Michele ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59267/#review175101 ----------------------------------------------------------- On Mag. 15, 2017, 12:51 p.m., Michele Milesi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59267/ > ----------------------------------------------------------- > > (Updated Mag. 15, 2017, 12:51 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3128 > https://issues.apache.org/jira/browse/SQOOP-3128 > > > Repository: sqoop-trunk > > > Description > ------- > > Fix for documentation issue SQOOP-3128. > Updated the Sqoop User Guide, section 25.8.2.2. Oracle Roles and Privileges. > > > Diffs > ----- > > src/docs/user/connectors.txt 7c54071 > > > Diff: https://reviews.apache.org/r/59267/diff/1/ > > > Testing > ------- > > No test executed: fixed a markdown file. > > > Thanks, > > Michele Milesi > >
