-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59843/
-----------------------------------------------------------
(Updated July 21, 2017, 8:25 p.m.)
Review request for Sqoop and Anna Szonyi.
Bugs: SQOOP-3196
https://issues.apache.org/jira/browse/SQOOP-3196
Repository: sqoop-trunk
Description
-------
Most of the MySQL third party test cases use MySQLTestUtils to get the test
database parameters because these parameters can be configured using system
properties.
One exception is MySQLAuthTest which uses a predefined database name, username
and password which cannot be configured.
The goal of this JIRA is to change MySQLAuthTest to use MySQLTestUtils since it
would make setting up a new test database easier and make the MySQL third party
test suite more consistent.
After changing MySQLAuthTest to use MySQLTestUtils I realized that
MySQLAllTablesTest was failing because MySQLAuthTest did not drop all the
tables it created so I needed to modify it to make sure all the created tables
are dropped. I did not want to add more code duplication to this test class so
I did some refactoring on it before addig the extra drop logic.
Diffs (updated)
-----
src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java
f9e3cde1ab5a083104a788f62064a809f2bca2aa
src/test/com/cloudera/sqoop/manager/MySQLAuthTest.java
d5cca5d2f2942ad7472692978ad4abda2fb765d3
src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java
6310a398b32a505113d5448089e6c300d983e73e
Diff: https://reviews.apache.org/r/59843/diff/4/
Changes: https://reviews.apache.org/r/59843/diff/3-4/
Testing
-------
Executed unit and third party test cases.
Thanks,
Szabolcs Vasas
