----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61615/ -----------------------------------------------------------
Review request for Sqoop and Boglarka Egyed. Bugs: SQOOP-3186 https://issues.apache.org/jira/browse/SQOOP-3186 Repository: sqoop-trunk Description ------- Add Sqoop1 (import + --incremental + --check-column) support for functions/expressions, for example: Example sqoop import \ --connect $MYCONN --username $MYUSER --password $MYPSWD \ --table T1 --target-dir /path/directory --merge-key C1 \ --incremental lastmodified --last-value '2017-01-01 00:00:00.0' \ --check-column nvl(C4,to_date('2017-01-01 00:00:00') Diffs ----- src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 891ed4d src/java/org/apache/sqoop/SqoopOptions.java 2eb3d8a src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1564bdc src/java/org/apache/sqoop/tool/ImportTool.java 807ec8c Diff: https://reviews.apache.org/r/61615/diff/1/ Testing ------- Manual testing, still working on adding test cases. This is first iteration, so code still need to be refined. I will update to latest trunk once suggestions are made. Thanks, Eric Lin