Re: Review Request 62492: SQOOP-3224 and SQOOP-3225: Mainframe FTP transfer should have an option to use binary mode for transfer and Mainframe module FTP listing parser should cater for larger datasets on disk

Mon, 25 Sep 2017 23:52:16 -0700 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/
-----------------------------------------------------------

(Updated Sept. 26, 2017, 6:51 a.m.)


Review request for Sqoop.


Changes
-------

Added SQOOP JIRAs to Bugs field


Bugs: SQOOP-3224 and SQOOP-3225
    https://issues.apache.org/jira/browse/SQOOP-3224
    https://issues.apache.org/jira/browse/SQOOP-3225


Repository: sqoop-trunk


Description
-------

Added --transfermode {ascii|binary} to support FTP transfer mode switching.


Diffs
-----

  src/java/org/apache/sqoop/SqoopOptions.java 587d4e1d 
  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java 
ea54b07f 
  
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeFTPFileEntryParser.java 
f0b87868 
  src/java/org/apache/sqoop/tool/MainframeImportTool.java 0cb91dbc 
  src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java f61b9838 
  
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeFTPFileEntryParser.java
 eb0f8c00 
  src/test/org/apache/sqoop/tool/TestMainframeImportTool.java d51e33e5 


Diff: https://reviews.apache.org/r/62492/diff/2/


Testing
-------

Unit tests.
Functional testing soon on a mainframe.


Thanks,

Chris Teoh

Reply via email to