> On Nov. 6, 2017, 2:03 p.m., Szabolcs Vasas wrote: > > src/test/com/cloudera/sqoop/io/TestLobFile.java > > Lines 615 (patched) > > <https://reviews.apache.org/r/63576/diff/2/?file=1881914#file1881914line615> > > > > I think if you use the spy method here just like you did in the > > createCryptoOutputStream method you can avoid the library upgrade.
This is indeed a more elegant solution, thanks for the suggestion! - Boglarka ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63576/#review190153 ----------------------------------------------------------- On Nov. 6, 2017, 2:46 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63576/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 2:46 p.m.) > > > Review request for Sqoop, Ferenc Szabo, Anna Szonyi, and Szabolcs Vasas. > > > Bugs: SQOOP-3243 > https://issues.apache.org/jira/browse/SQOOP-3243 > > > Repository: sqoop-trunk > > > Description > ------- > > Importing BLOB data causes "Stream closed" error on encrypted HDFS because > Sqoop tries to close CryptoOutputStream twice in LobFile class. This error > was ignored with Java 7 implementation of FilterOutputStream butis propagated > to upper levels in Java 8 thus the error occurs with BLOB import. > > > Diffs > ----- > > src/java/org/apache/sqoop/io/LobFile.java > 4e1bf2cb4a356ba1a2fc3aeca12859bbeb329cd4 > src/test/com/cloudera/sqoop/io/TestLobFile.java > 029758c531b0214b9b7f82de59d8fbae61bfdb0a > > > Diff: https://reviews.apache.org/r/63576/diff/3/ > > > Testing > ------- > > I have added a new test case, I also needed to bump the Mockito version and > upon that some other test cases needed to be updated as well due to some > Mockito backward incompatibility issues. > Ran unit and 3rd party tests successfully. > > > Thanks, > > Boglarka Egyed > >
