----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64034/#review191838 -----------------------------------------------------------
Fix it, then Ship it! Hi Szabi, This is a very nice improvement, thank you very much for your contribution! You have left out the license headers from the new files, please add them. Otherwise I ran unit and 3rd party tests successfully with your patch. Thanks, Bogi src/java/org/apache/sqoop/metastore/PasswordRedactor.java Lines 1 (patched) <https://reviews.apache.org/r/64034/#comment269777> Please add licence header to this file. src/test/org/apache/sqoop/metastore/PasswordRedactorTest.java Lines 1 (patched) <https://reviews.apache.org/r/64034/#comment269778> Please add licence header to this file. - Boglarka Egyed On Nov. 22, 2017, 4:54 p.m., Szabolcs Vasas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64034/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 4:54 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3257 > https://issues.apache.org/jira/browse/SQOOP-3257 > > > Repository: sqoop-trunk > > > Description > ------- > > If sqoop.metastore.client.record.password property is set to true then Sqoop > stores the database password in the metastore. The problem is that in this > case the password can be logged by a couple of classes which needs to be > avoided. > > > Diffs > ----- > > src/java/org/apache/sqoop/SqoopJobDataPublisher.java > 93be02fa00aab091707b42b32c8a638a881bdf50 > src/java/org/apache/sqoop/SqoopOptions.java > 587d4e1dd4012692ca7c742bcd518f55c10d1f8f > src/java/org/apache/sqoop/metastore/GenericJobStorage.java > 9e1b18b6dad08991e11e41435bf62ea87b534f2f > src/java/org/apache/sqoop/metastore/PasswordRedactor.java PRE-CREATION > src/java/org/apache/sqoop/tool/JobTool.java > dbe89349c17ca86c3985c279cb3fe150e3bcab0e > src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java > bd911f224496688bae811767c1b559f88965a571 > src/test/org/apache/sqoop/metastore/PasswordRedactorTest.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/64034/diff/1/ > > > Testing > ------- > > Unit tests and third party tests are executed. > > > Thanks, > > Szabolcs Vasas > >
