----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64251/#review193660 -----------------------------------------------------------
Hi Bogi, Thank you for filling this gap in our documentation, I have found a few minor things, please double check them. Thanks, Szabolcs COMPILING.txt Lines 147 (patched) <https://reviews.apache.org/r/64251/#comment272243> I think the correct parameter name here is ms.sqlserver.username, can you please double check? COMPILING.txt Lines 148 (patched) <https://reviews.apache.org/r/64251/#comment272244> I think the correct parameter name here is ms.sqlserver.password, can you please double check? - Szabolcs Vasas On Dec. 7, 2017, 4:46 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64251/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2017, 4:46 p.m.) > > > Review request for Sqoop, Fero Szabo and Szabolcs Vasas. > > > Bugs: SQOOP-3266 > https://issues.apache.org/jira/browse/SQOOP-3266 > > > Repository: sqoop-trunk > > > Description > ------- > > MSSQL tests have been added to 3rd part test suite in SQOOP-3174, > COMPILING.txt should be updated accordingly. Also, 3rd party test execution > on native database servers could be more verbose. > > > Diffs > ----- > > COMPILING.txt f531dd49a77d86b747478b4b8aad1a62d63515af > > > Diff: https://reviews.apache.org/r/64251/diff/2/ > > > Testing > ------- > > Only text change. > > > Thanks, > > Boglarka Egyed > >
