[ https://issues.apache.org/jira/browse/SQOOP-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316138#comment-16316138 ]
ASF GitHub Bot commented on SQOOP-3273: --------------------------------------- GitHub user szvasas opened a pull request: https://github.com/apache/sqoop/pull/42 Cloudera package removal This pull request is created for: https://issues.apache.org/jira/browse/SQOOP-3273 Corresponding RD review is: https://reviews.apache.org/r/65017 You can merge this pull request into a Git repository by running: $ git pull https://github.com/szvasas/sqoop cloudera_package_removal Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sqoop/pull/42.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #42 ---- commit 22122ff17d656455674aaad5dcc0d7d35a338944 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:12:36Z com.cloudera.sqoop.cli.RelatedOptions is not used anymore. commit dbcca41ef0c51386759c85e1b748e5ed25344752 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:14:56Z com.cloudera.sqoop.cli.SqoopParser is not used anymore. commit 8874646ec1c13800afc9b67227b443caa01309ff Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:18:57Z com.cloudera.sqoop.cli.ToolOptions is not used anymore. commit e5dfa077dffd35d16a317e3c94a8e70ece5c5f70 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:23:21Z com.cloudera.sqoop.config.ConfigurationHelper is not used anymore. commit 7d7438ed3b05e68211342815927a587cd27fe4fb Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:24:42Z com.cloudera.sqoop.hbase.HBasePutProcessor is not used anymore. commit 49098cf204f409350a5cb943c057379c41b29860 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:26:52Z com.cloudera.sqoop.hbase.HBaseUtil is not used anymore. commit 5bd9d96c31c3e199e5d614f2b0f8d1fdcc169f96 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:27:42Z com.cloudera.sqoop.hbase.PutTransformer is not used anymore. commit 7f08298bc5cf1bbe91f4d36e6af7d78461507b97 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:30:14Z com.cloudera.sqoop.hive.HiveImport is not used anymore. commit f03816d12e9a1dcf4ef4e486fbbd625871307962 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:31:14Z com.cloudera.sqoop.hive.HiveTypes is not used anymore. commit e02b278dcd6a405c0ab35531ff1fc489edae92c0 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:32:54Z com.cloudera.sqoop.hive.TableDefWriter is not used anymore. commit db3e3b76a4b33adc2b35df44653fcd3ae54455c9 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:35:53Z com.cloudera.sqoop.io.CodecMap is not used anymore. commit 38c370e8283b6af0a878f528964bc51631207197 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:44:47Z com.cloudera.sqoop.io.LobFile and its inner classes are not used anymore. The class had to be commented out because the interface of its super class is modified. commit 6f25e4acff7c2f807a787a31694a619c89d31af8 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:48:01Z com.cloudera.sqoop.io.NamedFifo is not used anymore. commit 569fca251023ac9ce67a326f9efa4f271c128dbb Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:51:46Z com.cloudera.sqoop.io.SplittableBufferedWriter is not used anymore. TestSplittableBufferedWriter had to be moved to org.apache package because it used a protected constructor. commit 349b8a825cc14da878962c113bb91aba35a15ad7 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:53:40Z com.cloudera.sqoop.io.SplittingOutputStream is now only used in com.cloudera.sqoop.io.SplittableBufferedWriter but it is not used anymore. commit 501cafb2fd0e811e72d07d14cd6b00e9bd24d876 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T10:59:06Z com.cloudera.sqoop.io.UnsupportedCodecException is not used anymore. com.cloudera.sqoop.io.CodecMap had to be commented out because the interface of its superclass has changed. commit ddc9fadf6a4cab66fc21c964c8def20472abe3dc Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T11:10:35Z com.cloudera.sqoop.lib.BigDecimalSerializer is not used anymore. commit dd58f7d8cb22cb4adf1a0f94aee6dd53f8460560 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T11:18:38Z com.cloudera.sqoop.lib.BlobRef is not used anymore. It had to be commented out because the super interface has changed. commit 7198ef4bdcd69bb17668cdd5da08a872c2bfb73c Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T11:20:32Z com.cloudera.sqoop.lib.BooleanParser is not used anymore. commit 49ba230efbc594f654d29d2117133230724d8fa2 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T11:26:13Z com.cloudera.sqoop.lib.ClobRef is not used anymore. It had to be commented out because the interface of its superclass has been changed. commit 0a7d42d73ab699a2f9353293fccd02565eaa4605 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T11:30:28Z com.cloudera.sqoop.lib.FieldFormatter is not used anymore. commit 079c3d01d394addeb64aeee0d01ca875fe271c35 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T12:25:17Z com.cloudera.sqoop.lib.FieldMappable is not used anymore. commit 65de738b541771dcac168ece3d97d8fae6e88f12 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T12:26:30Z com.cloudera.sqoop.lib.FieldMapProcessor is not used anymore. commit 45ede417f75d339384c2545a947dfc0da9f53d46 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T12:31:09Z com.cloudera.sqoop.lib.JdbcWritableBridge is not used anymore. commit cfeb54f4e64de759cbfcbce9c186213b077bb9dd Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T12:40:14Z com.cloudera.sqoop.lib.LargeObjectLoader is not used anymore. commit 4b2c9eee01a1a5da9ba7fd09cf5371e13a2a8550 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T12:41:38Z com.cloudera.sqoop.lib.LobRef is not used anymore. commit 8ad3bc2c0f3eafb800e387b1c83d9d8061775904 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T12:42:12Z com.cloudera.sqoop.lib.LobSerilaizer is not used anymore. commit 4323d62d114c2ba85a9b7a9fc6a09b5aeffe8384 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T12:48:00Z com.cloudera.sqoop.lib.RecordParser is not used anymore. commit 406817dadebb41433bc7ae21420bc9aff30f9891 Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T12:57:30Z com.cloudera.sqoop.lib.SqoopRecord is not used anymore. commit feacaf3ad09e0c33f5b2b3bc3f7dc067bf7ae50e Author: Szabolcs Vasas <vasas@...> Date: 2017-12-18T12:59:22Z com.cloudera.sqoop.manager.CatalogQueryManager is not used anymore. ---- > Removing com.cloudera.sqoop packages > ------------------------------------ > > Key: SQOOP-3273 > URL: https://issues.apache.org/jira/browse/SQOOP-3273 > Project: Sqoop > Issue Type: Improvement > Reporter: Szabolcs Vasas > Assignee: Szabolcs Vasas > > Sqoop has dozens of classes in com.cloudera.sqoop packages which most of the > cases just extend their corresponding class in org.apache.sqoop package > without adding extra functionality. > These classes make the code harder to read and navigate, they are already > deprecated but because of backward compatibility considerations we have not > removed them yet. > The task is to make sure that all the functionality from com.cloudera.sqoop > classes is available in org.apache.sqoop classes and remove the classes from > com.cloudera.sqoop packages. > The tests defined in com.cloudera.sqoop packages should also be migrated to > org.apache.sqoop package. -- This message was sent by Atlassian JIRA (v6.4.14#64029)