----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65734/#review197858 -----------------------------------------------------------
src/java/org/apache/sqoop/manager/OracleManager.java Line 652 (original), 652 (patched) <https://reviews.apache.org/r/65734/#comment278145> Hey Daniel, Have you considered using SYSTIMESTAMP? AFAIK it's also a timestamp with timezone. Why is CURRENT_TIMESTAMP better for our cause? Thanks, Attila - Attila Szabo On Feb. 21, 2018, 2:23 p.m., daniel voros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65734/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2018, 2:23 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3288 > https://issues.apache.org/jira/browse/SQOOP-3288 > > > Repository: sqoop-trunk > > > Description > ------- > > At the moment we're using SELECT SYSDATE FROM dual when getting current time > from Oracle. > > SYSDATE returns the underlying operating system's current time, while > CURRENT_TIMESTAMP uses the session time zone. This could lead to problems > during incremental imports when Oracle's time zone is different from the OS. > > See descrition of SQOOP-3288 for details. > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/OracleManager.java 12613e3 > > > Diff: https://reviews.apache.org/r/65734/diff/1/ > > > Testing > ------- > > - run oracle incremental tests > - tested on a cluster with saved and non-saved job as well > > > Thanks, > > daniel voros > >
