----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66062/ -----------------------------------------------------------
(Updated March 21, 2018, 1:20 p.m.) Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Changes ------- Hi Szabi, I removed the line you mentioned, but now I get the following error (probably because of a bad env setup): real-docs: [exec] asciidoc --unsafe -b docbook -d manpage -a "author=Sqoop Team" man/sqoop-codegen.txt [exec] /bin/sh: lsb_release: command not found [exec] xmlto man man/sqoop-codegen.xml -o man [exec] xmlto: /Users/ferencszabo/workspace/sqoop/src/docs/man/sqoop-codegen.xml does not validate (status 3) [exec] xmlto: Fix document syntax or use --skip-validation option [exec] I/O error : Attempt to load network entity http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd [exec] /Users/ferencszabo/workspace/sqoop/src/docs/man/sqoop-codegen.xml:2: warning: failed to load external entity "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd" [exec] D DocBook XML V4.5//EN" "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd" [exec] ^ [exec] I/O error : Attempt to load network entity http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd [exec] warning: failed to load external entity "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd" [exec] validity error : Could not load the external subset "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd" [exec] Document /Users/ferencszabo/workspace/sqoop/src/docs/man/sqoop-codegen.xml does not validate [exec] make: *** [man/sqoop-codegen.1.gz] Error 13 Do you happen to know what the problem might be? In any case, this might warrant a fix in another Jira.. Bugs: SQOOP-3292 https://issues.apache.org/jira/browse/SQOOP-3292 Repository: sqoop-trunk Description ------- Documentation for avro decimal padding i.e. the sqoop.avro.logical_types.decimal.enable flag. I also added a few lines to mention sqoop.avro.logical_types.decimal.enable, because the two goes hand in hand. Also fixed 2 typos. Diffs (updated) ----- src/docs/user/import.txt 330d5445 Diff: https://reviews.apache.org/r/66062/diff/2/ Changes: https://reviews.apache.org/r/66062/diff/1-2/ Testing ------- Thanks, Fero Szabo