----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66067/#review199766 -----------------------------------------------------------
Hi Anna, This is a superb improvement in Sqoop, many thanks for taking this huge effort! Using Gradle would indeed ease the life of the developers as well as let more enhancements to come in the future. However I was not able to apply your patch, I got the following error message: error: patch failed: COMPILING.txt:403 error: COMPILING.txt: patch does not apply /Users/boglarka.egyed/Downloads/SQOOP-3052.patch:1178: new blank line at EOF. Could you please update the patch file? I also took a first glance and found some minor things, please find them below. Many thanks, Bogi COMPILING.txt Lines 206 (patched) <https://reviews.apache.org/r/66067/#comment280211> Typo: gralew COMPILING.txt Lines 215 (patched) <https://reviews.apache.org/r/66067/#comment280212> Typo: gralew gradlew Lines 1 (patched) <https://reviews.apache.org/r/66067/#comment280213> License information header is missing from this file. - Boglarka Egyed On March 19, 2018, 1:55 p.m., Anna Szonyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66067/ > ----------------------------------------------------------- > > (Updated March 19, 2018, 1:55 p.m.) > > > Review request for Sqoop. > > > Bugs: Sqoop-3052 > https://issues.apache.org/jira/browse/Sqoop-3052 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer > friendly / open > > > Diffs > ----- > > .gitignore 68cbe28 > COMPILING.txt 86be509 > build.gradle PRE-CREATION > buildSrc/customUnixStartScript.txt PRE-CREATION > buildSrc/customWindowsStartScript.txt PRE-CREATION > buildSrc/sqoop-package.gradle PRE-CREATION > buildSrc/sqoop-version-gen.gradle PRE-CREATION > config/checkstyle/checkstyle-java-header.txt PRE-CREATION > config/checkstyle/checkstyle-noframes.xsl PRE-CREATION > config/checkstyle/checkstyle.xml PRE-CREATION > gradle.properties PRE-CREATION > gradlew PRE-CREATION > gradlew.bat PRE-CREATION > settings.gradle PRE-CREATION > > > Diff: https://reviews.apache.org/r/66067/diff/1/ > > > Testing > ------- > > ran all new tasks, except for internal maven publishing > > Notes: > - To try it out you can call ./gradlew tasks --all to see all the tasks and > compare them to current tasks/artifacts. > - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier > to combine all test results into a single report. > - Generated pom.xml now has correct dependencies/versions > - Script generation is currently hardcoded and not based on sqoop help, as > previously - though added the possiblity of hooking it in later > > > Thanks, > > Anna Szonyi > >
