----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66282/#review199972 -----------------------------------------------------------
Ship it! Nice addition, ship it! - daniel voros On March 26, 2018, 2:02 p.m., Szabolcs Vasas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66282/ > ----------------------------------------------------------- > > (Updated March 26, 2018, 2:02 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3308 > https://issues.apache.org/jira/browse/SQOOP-3308 > > > Repository: sqoop-trunk > > > Description > ------- > > This patch removes the externalColTypes field from TableDefWriter since it > was only used for testing purposes. > TestTableDefWriter is fixed to mock the ConnManager object provided to the > TableDefWriter constructor and a minor refactoring is done on the class. > > > Diffs > ----- > > src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 > src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 > > > Diff: https://reviews.apache.org/r/66282/diff/3/ > > > Testing > ------- > > ant clean test > > > Thanks, > > Szabolcs Vasas > >
