----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66221/#review200035 -----------------------------------------------------------
Hi Feró, Thank you for your effort improving our documentation! Please see my comments in-line. src/docs/man/sqoop-metastore.txt Lines 29 (patched) <https://reviews.apache.org/r/66221/#comment280622> I think there is some confusion here. The sqoop-metastore command is only for starting a shared metastore the meta-connect/meta-user/meta-password options are parameters for sqoop-job. Even if sqoop-job supports connecting to many different types of RDBMSs, the sqoop-metastore can only start an HSQLDB database. It could be great if you could clarify this in the docs. src/docs/man/sqoop-metastore.txt Lines 38 (patched) <https://reviews.apache.org/r/66221/#comment280623> These examples are great, but they should probably go to the sqoop-job man page and/or sqoop-job user guide page. src/docs/man/sqoop-metastore.txt Lines 41 (patched) <https://reviews.apache.org/r/66221/#comment280620> Typo: metastore src/docs/man/sqoop-metastore.txt Lines 45 (patched) <https://reviews.apache.org/r/66221/#comment280621> Typo: metastore src/docs/user/metastore-purpose.txt Line 20 (original), 20 (patched) <https://reviews.apache.org/r/66221/#comment280624> sqoop-metastore supports HSQLDB only. src/docs/user/saved-jobs.txt Line 231 (original), 231 (patched) <https://reviews.apache.org/r/66221/#comment280625> sqoop-metastore supports HSQLDB only. src/docs/user/saved-jobs.txt Line 247 (original), 247 (patched) <https://reviews.apache.org/r/66221/#comment280626> I would not delete this piece of information, it could be helpful for some users. src/docs/user/saved-jobs.txt Lines 250 (patched) <https://reviews.apache.org/r/66221/#comment280627> I think this information is really useful but I suggest putting it to the sqoop-job part of the documentation. - Szabolcs Vasas On March 22, 2018, 5:46 p.m., Fero Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66221/ > ----------------------------------------------------------- > > (Updated March 22, 2018, 5:46 p.m.) > > > Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. > > > Bugs: SQOOP-3301 > https://issues.apache.org/jira/browse/SQOOP-3301 > > > Repository: sqoop-trunk > > > Description > ------- > > This is the documentation for the metastore related patch implemented by Zach > Berkowitz. > > > Diffs > ----- > > src/docs/man/sqoop-metastore.txt c10cc08d > src/docs/user/metastore-purpose.txt 95c2d774 > src/docs/user/saved-jobs.txt 6885079f > > > Diff: https://reviews.apache.org/r/66221/diff/1/ > > > Testing > ------- > > ant docs ran successfully > > > Thanks, > > Fero Szabo > >
