> On July 12, 2018, 3:41 p.m., Szabolcs Vasas wrote: > > src/test/org/apache/sqoop/TestAppendUtils.java > > Lines 331 (patched) > > <https://reviews.apache.org/r/67424/diff/3/?file=2058941#file2058941line331> > > > > Nit: can you please use generic List here, otherwise the compiler gives > > a warning: > > List<String> args = new ArrayList<>();
I updated to ArrayList<String> args = new ArrayList<>(); instead of List<String> args = new ArrayList<>();, since List<String> will cause error in function runAppendTest(args, output, prefix). - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67424/#review206012 ----------------------------------------------------------- On July 13, 2018, 5:25 a.m., Eric Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67424/ > ----------------------------------------------------------- > > (Updated July 13, 2018, 5:25 a.m.) > > > Review request for Sqoop and Boglarka Egyed. > > > Bugs: SQOOP-3330 > https://issues.apache.org/jira/browse/SQOOP-3330 > > > Repository: sqoop-trunk > > > Description > ------- > > When adding --append to Sqoop directory import with > -Dmapreduce.output.basename, all files will be ignored, which end up nothing > being imported. See below DEBUG output: > > {code} > sqoop import -Dmapreduce.output.basename="eric-test" --connect > jdbc:mysql://mysql-host.com/test --username root --password 'root' --table > test --target-dir /tmp/ericlin-test/sqoop/test --fields-terminated-by '\t' > --verbose --append > > 18/05/28 22:24:44 INFO util.AppendUtils: Appending to directory test > 18/05/28 22:24:44 DEBUG util.AppendUtils: Filename: _SUCCESS ignored > 18/05/28 22:24:44 DEBUG util.AppendUtils: Filename: eric-test-m-00000 ignored > 18/05/28 22:24:44 DEBUG util.AppendUtils: Filename: eric-test-m-00001 ignored > 18/05/28 22:24:44 DEBUG util.AppendUtils: Filename: eric-test-m-00002 ignored > 18/05/28 22:24:44 DEBUG util.AppendUtils: Deleting temporary folder > 14935e396acc4ea7b9a6236c66064c9b_test > {code} > > This is due to AppendUtils only recognizes file name starts with > "part.*-([0-9]" > > https://github.com/apache/sqoop/blob/branch-1.4.7/src/java/org/apache/sqoop/util/AppendUtils.java#L46 > > > Diffs > ----- > > src/java/org/apache/sqoop/util/AppendUtils.java fa852804 > src/test/org/apache/sqoop/TestAppendUtils.java f14fc6ad > > > Diff: https://reviews.apache.org/r/67424/diff/4/ > > > Testing > ------- > > Added test case + manual test in VM > > > Thanks, > > Eric Lin > >
