----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68032/#review206388 -----------------------------------------------------------
Hi Bogi, Thanks for submitting this patch, it will be great to use the Java 8 features in Sqoop finally. I have left a minor comment and apart from that we should remove '-XX:PermSize=256m', '-XX:MaxPermSize=512m' parameters from the jvmArgs properties in build.gradle since these JVM arguments are not supported in Java 8. Szabolcs src/docs/man/sqoop.txt Line 44 (original), 44 (patched) <https://reviews.apache.org/r/68032/#comment289321> We should change Sun to Oracle as well since it has been already acquired. The download link is redirected to Oracle but it would be better to change to an Oracle download link. - Szabolcs Vasas On July 24, 2018, 12:49 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68032/ > ----------------------------------------------------------- > > (Updated July 24, 2018, 12:49 p.m.) > > > Review request for Sqoop, Fero Szabo and Szabolcs Vasas. > > > Bugs: SQOOP-3352 > https://issues.apache.org/jira/browse/SQOOP-3352 > > > Repository: sqoop-trunk > > > Description > ------- > > * Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml > * Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties > * Updated documentation > > > Diffs > ----- > > COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b > README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 > build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff > gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 > src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a > > > Diff: https://reviews.apache.org/r/68032/diff/1/ > > > Testing > ------- > > Successfully ran with ant: > ant > ant clean compile > ant clean package > ant clean test > ant cobertura -Dcobertura.home=/path/to/cobertura > ant clean test -Dthirdparty=<path_to_thirdparty_lib_directory> ... > ant checkstyle > ant mvn-install > ant docs > ant eclipse > > Succesfully ran with gradle: > ./gradlew clean > ./gradlew package > ./gradlew test > ./gradlew jacocoTestReport > ./gradlew -Dsqoop.thirdparty.lib.dir=<path_to_thirdparty_lib_directory> > thirdPartyTest > ./gradlew checkStyleMain > ./gradlew compileJava > ./gradlew publishToMavenLocal > > > Thanks, > > Boglarka Egyed > >
