----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68254/#review207035 -----------------------------------------------------------
Ship it! Thanks for this fix Nguyen! - Boglarka Egyed On Aug. 7, 2018, 9:33 a.m., Nguyen Truong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68254/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2018, 9:33 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3357 > https://issues.apache.org/jira/browse/SQOOP-3357 > > > Repository: sqoop-trunk > > > Description > ------- > > MainframeImportTool used to refer to the MainframeManager with a string. I > changed the string to a MainframeManager class reference. > > > Diffs > ----- > > src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d > src/test/org/apache/sqoop/manager/TestMainframeManager.java 97e48e88 > > > Diff: https://reviews.apache.org/r/68254/diff/1/ > > > Testing > ------- > > I ran ant test and did not add any more test case because my change was > already covered. > > > Thanks, > > Nguyen Truong > >
