-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68024/
-----------------------------------------------------------
(Updated Aug. 10, 2018, 10:23 a.m.)
Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
Changes
-------
Corrected all review findings
Bugs: SQOOP-3348
https://issues.apache.org/jira/browse/SQOOP-3348
Repository: sqoop-trunk
Description
-------
* Added hadoop-aws dependency
* Added an Amazon S3 credential generator logic to enable automated testing
* Added s3.bucket.url and s3.generator.command properties for testing purposes
* Added first S3 import test cases for text, Avro and Sequence file formats
* Extended COMPILING.txt with Amazon S3 test running guide
Diffs (updated)
-----
COMPILING.txt 4b61b11bcb6c3d0e0053018d206b36fdf6d4d3fc
build.gradle 99a4e24fbe6c2273402f780712080143896778fd
build.xml 8115b026f336be87b4ea41febbef5da78b9de33f
ivy.xml e55172e11b0ac1d8facf273f59393afc7e212af4
src/test/org/apache/sqoop/s3/TestS3AvroImport.java PRE-CREATION
src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java PRE-CREATION
src/test/org/apache/sqoop/s3/TestS3TextImport.java PRE-CREATION
src/test/org/apache/sqoop/testutil/DefaultS3CredentialGenerator.java
PRE-CREATION
src/test/org/apache/sqoop/testutil/S3CredentialGenerator.java PRE-CREATION
src/test/org/apache/sqoop/testutil/S3TestUtils.java PRE-CREATION
src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java PRE-CREATION
src/test/org/apache/sqoop/testutil/TextFileTestUtils.java PRE-CREATION
Diff: https://reviews.apache.org/r/68024/diff/2/
Changes: https://reviews.apache.org/r/68024/diff/1-2/
Testing
-------
Added new S3 import test cases with text, Avro and Sequence file formats.
ant clean test -Ds3.bucket.url=<bucket-url>
-Ds3.generator.command=<credential-generator-command>
Thanks,
Boglarka Egyed
