> On Oct. 24, 2018, 12:21 p.m., Szabolcs Vasas wrote:
> > src/docs/user/connectors.txt
> > Lines 41 (patched)
> > <https://reviews.apache.org/r/68064/diff/1/?file=2064419#file2064419line41>
> >
> >     Are you sure import-all-tables supports --schema properly?
> >     By looking at the code of this command it seems to me that Sqoop uses 
> > the list-tables command to get the table names it wants to import but then 
> > it invokes the import command in a loop to import all the tables. So I 
> > think that even if the list-tables shows a table the import command will 
> > not be able to pick it up.
> 
> Fero Szabo wrote:
>     Hi Szabi,
>     
>     Yes, I've tested this in July, when I created the review. Now this 
> reminds me to write down everything. :)
>     
>     Anyway, I've tested again, and this works as expected. What I did was: 
> fire up a cluster, created a couple of tables in a DB2 instance and ran the 
> command. 2 different schemas, all the data form all of the tables are in 
> hdfs. I'd say this is proper behavior.
>     
>     Now I'm not sure why/how this feature wasn't implemented for a (simple) 
> import, but it just wasn't. The error message suggests that sqoop tries to 
> use the default schema, i.e. DB2INST1. We can open a Jira if there isn't one.
>     
>     I'm dropping this issue.

Thank you for double checking this!


- Szabolcs


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68064/#review209952
-----------------------------------------------------------


On July 26, 2018, 2:58 p.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68064/
> -----------------------------------------------------------
> 
> (Updated July 26, 2018, 2:58 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3355
>     https://issues.apache.org/jira/browse/SQOOP-3355
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Adding documentation for a previously implemented feature. This one is quite 
> simple.
> 
> 
> Diffs
> -----
> 
>   src/docs/user/connectors.txt 59e3e00b 
> 
> 
> Diff: https://reviews.apache.org/r/68064/diff/1/
> 
> 
> Testing
> -------
> 
> ant docs, 
> + unit and 3rd party tests, though these shouldn't be affected.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>

Reply via email to