----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/#review210796 -----------------------------------------------------------
Ship it! Ship It! - Boglarka Egyed On Nov. 22, 2018, 1:39 p.m., Fero Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69407/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2018, 1:39 p.m.) > > > Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. > > > Bugs: SQOOP-3405 > https://issues.apache.org/jira/browse/SQOOP-3405 > > > Repository: sqoop-trunk > > > Description > ------- > > Breaking up the parameterized test classes into a per database basis. > Provides better readability, needed for proper test categorization (and thus, > for travis integration). > > > Diffs > ----- > > src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java > PRE-CREATION > src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cbe2 > src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbbd3 > > src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java > 4ad7defe1 > > src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java > fbcbdebeb > > src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java > PRE-CREATION > > src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java > PRE-CREATION > > src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java > PRE-CREATION > > src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java > PRE-CREATION > src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java > PRE-CREATION > src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java > PRE-CREATION > src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java > PRE-CREATION > src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java > PRE-CREATION > src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java > 22567162d > src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java > ebd014688 > > > Diff: https://reviews.apache.org/r/69407/diff/7/ > > > Testing > ------- > > unit and 3rd party tests. > > > Thanks, > > Fero Szabo > >
