[
https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704819#comment-16704819
]
ASF GitHub Bot commented on SQOOP-3396:
---------------------------------------
Github user fszabo2 commented on a diff in the pull request:
https://github.com/apache/sqoop/pull/60#discussion_r237881838
--- Diff:
src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java
---
@@ -65,4 +66,21 @@
public String toString() {
return getClass().getSimpleName();
}
+
+ @Override
+ public Object[] getExpectedResultsForHive() {
--- End diff --
Hi Attila,
I'd like to leave these as is.
I'd argue that these don't actually belong together, so it's not really
code duplication but rather an accidental match.
I added a new column to the sample data of the mysql configuration to cover
an edge case. The expected result in Hive changed for this configuration, and,
on the other hand this edge case does not make sense to be added to the SQL
server tests.
> Add parquet numeric support for Parquet in Hive import
> ------------------------------------------------------
>
> Key: SQOOP-3396
> URL: https://issues.apache.org/jira/browse/SQOOP-3396
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Fero Szabo
> Assignee: Fero Szabo
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
