[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

[szvasas]

Github user szvasas commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/60#discussion_r237907664
  
    --- Diff: src/java/org/apache/sqoop/hive/HiveTypes.java ---
    @@ -79,8 +85,42 @@ public static String toHiveType(int sqlType) {
               default:
             // TODO(aaron): Support BINARY, VARBINARY, LONGVARBINARY, DISTINCT,
             // BLOB, ARRAY, STRUCT, REF, JAVA_OBJECT.
    -        return null;
    +            return null;
    +      }
    +  }
    +
    +  private static String mapDecimalsToHiveType(int sqlType, SqoopOptions 
options) {
    +    if 
(options.getConf().getBoolean(ConfigurationConstants.PROP_ENABLE_PARQUET_LOGICAL_TYPE_DECIMAL,
 false)
    +        && (sqlType == Types.NUMERIC || sqlType == Types.DECIMAL)){
    --- End diff --
    
    Do we need to test for NUMERIC and DECIMAL types again here?


---