[ 
https://issues.apache.org/jira/browse/SQOOP-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302253#comment-17302253
 ] 

Attila Szabo commented on SQOOP-3487:
-------------------------------------

Hi [~zhou0145] ,

I've reviewed your changes (both Github and issues.apache.org), but TBH in the 
current state I'm concerned both about the intention of the change, and the 
correctness as well.

First of all:
Could you please provide a bit more detail around what performance gain do you 
expect from this change and how did you measure it? Could you please provide 
also some automated testcase which would show the effect of this gain, and 
would ensure we don't loose it in the future?

On the front of correctness:
SQOOP-3149 introduced the line you'd like to remove, and if I do remember 
correctly absolutely intentionally. Because of this reason:
Could you please provide automated test cases which ensures that SQOOP-3149 
changes won't be undone by your change (so we keep the current correctness 
around NULL column updates)?

Many thanks in advance,
[~maugli]

> Add PUT repeatedly when importing to HBase
> ------------------------------------------
>
>                 Key: SQOOP-3487
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3487
>             Project: Sqoop
>          Issue Type: Improvement
>          Components: hbase-integration
>    Affects Versions: no-release
>         Environment: sqoop-version:1.4.7-cdh6.3.2
>            Reporter: hong
>            Priority: Major
>              Labels: hbase
>             Fix For: no-release
>
>         Attachments: 
> 0001-SQOOP-3487-Add-PUT-repeatedly-when-importing-to-HBas.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Repeated add of PUT cause the import into HBase to slow down



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to