On Mon, Sep 24, 2012 at 1:37 PM, Bertrand Delacretaz <[email protected] > wrote:
> On Mon, Sep 24, 2012 at 12:19 PM, Reto Bachmann-Gmür <[email protected]> > wrote: > > On Mon, Sep 24, 2012 at 8:54 AM, Bertrand Delacretaz < > [email protected] > >> On Sunday, September 23, 2012, Reto Bachmann-Gmür wrote: > >> > ...I think the tests shold not access external services... > >> Yes - there's OfflineMode for that. > >> > > ...The offline mode is for not updating libraries from the remote repos. > If I > > have the libraries in the local repository I can use the offline mode. If > > tests are skipped in offline mode this means that some projects might > buil > > with -o and fail otherwise... > > Sorry I was too terse maybe, didn't mean maven's offline mode, but the > STANBOL-86 OfflineMode service, which allows you to modify your > service's behavior when the system should not make any external > requests, which IMO is needed when running our automated tests. > The test that was failing was a unit tests that doesn't use OSGi and thus couldn't use STANBOL-86. For the integration tests STANBOL-86 seems a good approach. If understand STANBOL-87 <https://issues.apache.org/jira/browse/STANBOL-87> correctly the integrations tests are always run in offline mode. I think the unit tests should always be offline while for the integration tests it might be good to have the options to check if things integrate with the outside world. Cheers, Reto > -Bertrand >
