I was just looking at the indentation in the
$TOPDIR/include/rw/_static_assert.h header.  Why are the defines within
the `#ifndef _RWSTD_NO_STATIC_ASSERT' indented but the directives
outside this #if/#else/#endif block are not?  Should they all be
indented uniformly or not indented at all?

I realize this is not conventional but if we want to indent
preprocessing directives, this file should look like this:

        #ifndef _RWSTD_RW_STATIC_ASSERT_H_INCLUDED
        #  define _RWSTD_RW_STATIC_ASSERT_H_INCLUDED

        #  include <rw/_defs.h>

        ...

        #  ifndef _RWSTD_NO_STATIC_ASSERT
        #    define _RWSTD_STATIC_ASSERT(Cond)
        ...
        #  else
        #    define _RWSTD_STATIC_ASSERT(Cond,Mesg) static_assert(Cond,
Mesg)
        #  endif   // _RWSTD_NO_STATIC_ASSERT

        #endif   // _RWSTD_RW_STATIC_ASSERT_H_INCLUDED

Otherwise, we shouldn't indent at all.

Thanks,
Brad.

Reply via email to