Eric Lemings wrote: > >> Travis Vitek wrote: >> >> >Modified: >stdcxx/branches/4.3.x/tests/utilities/20.tuple.creation.cpp >... >> >+ rw_assert (0 == std::strcmp (s, "string"), __FILE__, __LINE__, >> >+ "s == \"string\", got false, expected true"); >> >> The tuple is holding the original pointer (not a copy), so I >think you >> can check the actual pointer here. > >True. But if that assumption became invalid for whatever reason, the >code above would still work. > >Assumptions are bad. Robustness is good. :)
As I see it, the tuple implementation is required to hold a copy of an object of the specified type (const char* in this case). If you don't verify the value held is indeed a copy, you are not actually verifying the requirements. This is wrong, and wrong is much worse than bad. :) > >Brad. >
