Martin Sebor wrote:
Travis Vitek wrote:
Author: sebor
Date: Tue Jul 29 09:24:16 2008
New Revision: 680756
Modified: stdcxx/branches/4.2.x/include/loc/_codecvt.h
URL: http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/include/loc/
_codecvt.h?rev=680756&r1=680755&r2=680756&view=diff
===============================================================
===============
--- stdcxx/branches/4.2.x/include/loc/_codecvt.h (original)
+++ stdcxx/branches/4.2.x/include/loc/_codecvt.h Tue Jul 29 09:24:16
2008
@@ -120,6 +120,8 @@
_EXPLICIT codecvt (_RWSTD_SIZE_T __ref = 0): _RW::__rw_facet
(__ref) { }
+ virtual ~codecvt () _RWSTD_ATTRIBUTE_NOTHROW;
+
Are you sure you don't want to be using _RWSTD_DECLARE_NOTHROW here, and
_RWSTD_DEFINE_NOTHROW with the definition. I only see
_RWSTD_ATTRIBUTE_NOTHROW being defined for gcc, and that means compile
error for all other configurations.
Whoops! You're right, this wouldn't work without a definition
of the macro on platforms that don't support the attribute.
I just checked in the change that adds this definition. Sorry
for the our-of-band commit! (I'm working with one local copy
too many...)
I just checked our build results from last night and I see
I really screwed things up yesterday. Sorry about that! I
don't know what happened. I thought I'd tested everything
several times with three different compilers (gcc, EDG eccp,
and Intel C++) but I must have only been testing with gcc...
Anyway, I just committed this patch to get rid of the errors:
http://svn.apache.org/viewvc?view=rev&revision=681102
Martin
