> On Mar 22, 2015, at 2:31 AM, Greg Stein <[email protected]> wrote:
> 
>> +                except:
>> +                    pass
>> 
> 
> Woah!!! ... No way. I don't know what you're trying to do with the above,
> but throwing away all exceptions is never the right answer. .... my brain
> locks up, seeing that. I need to self-censor.

I didn’t have a chance to read the fix but I want also add that in addition to 
adding a simple pass to an except: clause, an empty except: statement is also 
dangerous.  It can eat signals that are sent to the process.  Always use the 
most concise Exception that you can use.


Regards,
Alan

Reply via email to