Re: svn commit: r1667520 - in /steve/trunk/pytest: ./ REST_API_README.txt httpd.conf steve.cfg www/ www/cgi-bin/ www/cgi-bin/lib/ www/cgi-bin/lib/__init__.py www/cgi-bin/lib/response.py www/cgi-bin/rest_admin.py www/cgi-bin/rest_voter.py www/htdocs/

[Alan D. Cabrera]

> On Mar 18, 2015, at 5:17 AM, humbed...@apache.org wrote:
> 
> +                            valid_types = 
> ['yna','stv1','stv2','stv3','stv4','stv5','stv6','stv7','stv8','stv9']
> +                            if not form.getvalue('type') in valid_types:


The variable valid_types is a constant and so it should be a tuple.  Since 
users of this code would be interested in what the library considers the list 
of valid types, it would be nice if VALID_TYPES, all caps, would be a module 
level variable defined at the top that clients could inspect.


Regards,
Alan