> On Mar 30, 2015, at 10:26 AM, Daniel Gruno <humbed...@apache.org> wrote: > > > > On 2015-03-30 17:10, Alan D. Cabrera wrote: >>> On Mar 30, 2015, at 3:17 AM, Daniel Gruno <humbed...@apache.org> wrote: >>> >>> >>> >>> On 2015-03-29 20:16, Alan Cabrera wrote: >>>> I was looking at our backend code and noticed that they are in charge of >>>> generating the election hash. In my opinion I think the election hash >>>> should be generated by the callers of the back end and not delegated to >>>> the back ends themselves. >>> What exactly do you mean by 'callers of the backend'? The person doing the >>> API call? or the library doing the final call to the DB backend? >> Actually, any caller but more specifically the library doing the final call >> to the DB backend. The code is duplicated and it’s mixing concerns in the >> DB backend code. > > I don't see any duplication - but maybe I removed that just don't remember? > (I'm a bit worn out atm). > From what I can see, election.py is the only one doing the hash.
Duh, sorry, I was working off an old copy. :) Regards, Alan
