gstein commented on PR #53: URL: https://github.com/apache/steve/pull/53#issuecomment-3449827185
Please do not import names from a module. All references should be MODULE.NAME so that a reader immediately knows where NAME is defined (without needing to search). For testing purposes, the random_owner() is still useful. For example, to run programmatic tests of a large set of data. The new --owner option can be optional. That's a great change for creating elections for interactive testing via the UX. Note the proper name is `owner_pid` (based on the `election.owner_pid` column), rather than the shortened `owner`. A simple `pid` is also allowable, especially if a function is introduced to validate the `pid` using a PersonDB instance. The pyproject.toml change is a bit gratuitous, but not a problem. If it is retained, then the two-space-hash for comments in the style to be used. (the change adds spaces to one line, and removes a space from another) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
