[
https://issues.apache.org/jira/browse/STORM-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015400#comment-14015400
]
ASF GitHub Bot commented on STORM-205:
--------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/101#discussion_r13285186
--- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
@@ -509,26 +231,23 @@
reverse
first)]
(if error
- [:span (if (< (time-delta (.get_error_time_secs ^ErrorInfo error))
- (* 60 30))
- {:class "red"}
- {})
- (error-subset (.get_error ^ErrorInfo error))]
- )))
+ (error-subset (.get_error ^ErrorInfo error))
+ "")))
-(defn component-link [storm-id id]
- (link-to (url-format "/topology/%s/component/%s" storm-id id)
(escape-html id)))
+(defn component-task-summs [^TopologyInfo summ topology id]
+ (let [spout-summs (filter (partial spout-summary? topology)
(.get_executors summ))
+ bolt-summs (filter (partial bolt-summary? topology)
(.get_executors summ))
+ spout-comp-summs (group-by-comp spout-summs)
+ bolt-comp-summs (group-by-comp bolt-summs)
+ ret (if (contains? spout-comp-summs id)
+ (spout-comp-summs id)
+ (bolt-comp-summs id))]
+ (sort-by #(-> ^ExecutorSummary % .get_executor_info .get_task_start)
ret)
+ ))
(defn worker-log-link [host port]
- (link-to (url-format "http://%s:%s/log?file=worker-%s.log";
- host (*STORM-CONF* LOGVIEWER-PORT) port) (str port)))
-
-(defn render-capacity [capacity]
- (let [capacity (nil-to-zero capacity)]
- [:span (if (> capacity 0.9)
- {:class "red"}
--- End diff --
Capacities may no longer be highlighted read if they are above 90%. I have
not tested this, but I could not find where we were applying this style with
the new templates. I do not think this is a very big deal, but it is a
regression of a feature that some users might want.
> Add REST API to Storm UI
> ------------------------
>
> Key: STORM-205
> URL: https://issues.apache.org/jira/browse/STORM-205
> Project: Apache Storm (Incubating)
> Issue Type: New Feature
> Reporter: P. Taylor Goetz
>
> It would be helpful to have a RESTful API to expose the metrics currently
> available in Storm UI.
> This would allow integration with 3rd-party monitoring and visualization
> services.
> The REST services could either be implemented within the Storm UI service, or
> as a separate Storm daemon.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
