GitHub user nielsbasjes opened a pull request:
https://github.com/apache/storm/pull/275
STORM-512 KafkaBolt doesn't handle ticks properly
I implemented this by
1. Adding an 'boolean isTick()' method to the Tuple interface.
This way it is for application builders much easier to determine if
the tuple at hand is a Tick or not.
2. Letting the KafkaBolt use that method to ignore the ticks.
3. Updating the other place in the code base that handles ticks
differently to use this new method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nielsbasjes/storm STORM-512
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/275.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #275
----
commit 6c6bec9b1b2b07b5dfb5000297c11911eda5389d
Author: Niels Basjes <[email protected]>
Date: 2014-10-01T09:50:48Z
New method in the Tuple interface "boolean isTuple()" for easier handling
of TickTuples.
commit 73e54a8f8b0ef9a62955c7c1cee20925d359772b
Author: Niels Basjes <[email protected]>
Date: 2014-10-01T09:51:42Z
KafkaBolt no longer tries to map/process/send Tick Tuples to Kafka.
commit 8888ae631360ad124af9c480d2f8b621b9c51727
Author: Niels Basjes <[email protected]>
Date: 2014-10-01T09:53:17Z
Use isTick in all relevant places to avoid code duplication.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
