[
https://issues.apache.org/jira/browse/STORM-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154767#comment-14154767
]
ASF GitHub Bot commented on STORM-506:
--------------------------------------
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/267#issuecomment-57460124
> @d2r @revans2 I ran a test with this PR the topology stats missing
complete latency and ack, fail numbers and also spout.
Does the topology have acking enabled? If not, all three stats should be
0. When testing, I modified storm.starter.clj.word_count to include an id when
emitting from the spouts, so that acking was enabled. It looked fine to me.
The second screenshot shows the error case when the acks for bolts are
summed and displayed in "Topology stats," and we do not want to count these
stats from the Bolts when we render "Topology stats." We want to count these
stats to track tuples that make it all the way through the tuple "tree," and
that means we must include only the spouts' stats.
> UI Counts acks & fails from bolts in "Topology Stats"
> -----------------------------------------------------
>
> Key: STORM-506
> URL: https://issues.apache.org/jira/browse/STORM-506
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Reporter: Derek Dagit
> Assignee: Derek Dagit
>
> The aggregation for the total topology statistics should count acks and fails
> for tuple "trees" only, but it includes acks and fails of bolts as well.
> [code|https://github.com/apache/storm/blob/cfcedcf4ad5e5c96fe3f30a0b710cfc604063231/storm-core/src/clj/backtype/storm/ui/core.clj#L344]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
