Github user ptgoetz commented on a diff in the pull request:

    https://github.com/apache/storm/pull/254#discussion_r18323164
  
    --- Diff: external/storm-kafka/src/jvm/storm/kafka/SpoutConfig.java ---
    @@ -26,8 +26,19 @@
         public Integer zkPort = null;
         public String zkRoot = null;
         public String id = null;
    +
    +    // setting for how often to save the current kafka offset to ZooKeeper
         public long stateUpdateIntervalMs = 2000;
     
    +    // Exponential back-off retry settings.  These are used when retrying 
messages after a bolt
    +    // calls OutputCollector.fail().
    +    //
    +    // Note: be sure to set backtype.storm.Config.MESSAGE_TIMEOUT_SECS 
appropriately to prevent
    +    // resubmitting the message while still retrying.
    --- End diff --
    
    Thanks for the clarification @rick-kilgore. If we can do something loud and 
obnoxious (I.e. Logging) in the fail method to let users know what is going on, 
that would help. I'd like to avoid allowing users potentially shooting 
themselves in the foot and getting into a difficult to debug situation.
    
    I'd also like to see some documentation in the README in that respect. 
    
    Thanks again!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to