[ 
https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159209#comment-14159209
 ] 

ASF GitHub Bot commented on STORM-492:
--------------------------------------

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/279#discussion_r18430254
  
    --- Diff: storm-core/src/clj/backtype/storm/testing.clj ---
    @@ -187,7 +187,9 @@
           ;; on windows, the host process still holds lock on the logfile
           (catch Exception e (log-message (.getMessage e)))) ))
     
    -(def TEST-TIMEOUT-MS 5000)
    +(def TEST-TIMEOUT-MS
    +  (let [timeout (System/getenv "STORM_TEST_TIMEOUT_MS")]
    +    (read-string (if timeout timeout "5000"))))
    --- End diff --
    
    @harshach Actually it's @ptgoetz suggestion, but parse-int is clearer that 
it should be number. I'll change it.


> Test timeout should be configurable
> -----------------------------------
>
>                 Key: STORM-492
>                 URL: https://issues.apache.org/jira/browse/STORM-492
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Devika Nair
>              Labels: newbie
>
> Test timeout is hard coded to 5000ms in 
> https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/testing.clj.
>  Provide a way to override this value in order to handle longer running tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to