GitHub user BuDongDong opened a pull request:
https://github.com/apache/storm/pull/288
update worker.clj-delete "missing-tasks" checking
missing-tasks set is created by two times filter my-assignment map, so i
think keys(my-assignment) contains missing-tasks set.
missing-tasks is always empty. (empty? missing-tasks) always return true.
(let [missing-tasks (->> needed-tasks
(filter (complement my-assignment)))]
(when-not (empty? missing-tasks)
(log-warn "Missing assignment for following tasks: "
(pr-str missing-tasks))
))
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BuDongDong/incubator-storm patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #288
----
commit 4b65d8152527f6770db6d103a7e2950f1a1f5f91
Author: zhangjinlong <[email protected]>
Date: 2014-10-09T09:48:00Z
update worker.clj-delete "missing-tasks" checking
missing-tasks set is created by two times filter my-assignment map, so i
think keys(my-assignment) contains missing-tasks set.
missing-tasks is always empty. (empty? missing-tasks) always return true.
(let [missing-tasks (->> needed-tasks
(filter (complement my-assignment)))]
(when-not (empty? missing-tasks)
(log-warn "Missing assignment for following tasks: "
(pr-str missing-tasks))
))
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
