[ 
https://issues.apache.org/jira/browse/STORM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173560#comment-14173560
 ] 

ASF GitHub Bot commented on STORM-532:
--------------------------------------

Github user itaifrenkel commented on a diff in the pull request:

    https://github.com/apache/storm/pull/293#discussion_r18945173
  
    --- Diff: 
storm-core/src/jvm/backtype/storm/spout/SleepSpoutWaitStrategy.java ---
    @@ -33,7 +33,7 @@ public void prepare(Map conf) {
         @Override
         public void emptyEmit(long streak) {
             try {
    -            Thread.sleep(sleepMillis);
    +            Thread.sleep(Math.abs(sleepMillis + streak));
    --- End diff --
    
    are you sure this is related to this pull request ?


> Supervisor should restart worker immediately, if the worker process does not 
> exist any more 
> --------------------------------------------------------------------------------------------
>
>                 Key: STORM-532
>                 URL: https://issues.apache.org/jira/browse/STORM-532
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.10.0
>            Reporter: caofangkun
>            Priority: Minor
>
> For now 
> if the worker process does not exist any more 
> Supervisor will have to wait a few seconds for worker heartbeart timeout and 
> restart worker .
> If supervisor knows the worker processid  and check if the process exists in 
> the sync-processes thread ,may need less time to restart worker.
> 1: record worker process id in the worker local heartbeart 
> 2: in supervisor  sync-processes ,get process id from worker local heartbeat 
> and check if the process exits 
> 3: if not restart it immediately



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to