[
https://issues.apache.org/jira/browse/STORM-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177634#comment-14177634
]
ASF GitHub Bot commented on STORM-538:
--------------------------------------
GitHub user drazzib opened a pull request:
https://github.com/apache/storm/pull/299
STORM-538: Also shade com.google.thirdparty.publicsuffix from Guava
Change storm-core/pom.xml to also relocate
com.google.thirdparty.publicsuffix
package to org.apache.storm.guava
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Dictanova/incubator-storm STORM-538
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #299
----
commit dc94bf47886c2c7b80f9eff8feec8054f6b9d43f
Author: Damien Raude-Morvan <[email protected]>
Date: 2014-10-20T23:05:36Z
STORM-538: Also shade com.google.thirdparty.publicsuffix from Guava
Change storm-core/pom.xml to also relocate
com.google.thirdparty.publicsuffix
package to org.apache.storm.guava
commit aae64a0b71ca5bf524bf38542afd43ae6f785252
Author: Damien Raude-Morvan <[email protected]>
Date: 2014-10-20T23:13:33Z
Merge branch 'master' into STORM-538
----
> Guava com.google.thirdparty.publicsuffix is not shaded
> ------------------------------------------------------
>
> Key: STORM-538
> URL: https://issues.apache.org/jira/browse/STORM-538
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.3
> Reporter: Damien Raude-Morvan
> Labels: shade
>
> Hi!
> I've just tried last 0.9.3-rc1 release which is available on
> http://storm.apache.org and I got an issue with seems to be linked to
> STORM-447.
> Here is the following stacktrace (stripping our package from trace) :
> {noformat}
> java.lang.NoSuchFieldError: EXACT
> at
> com.google.common.net.InternetDomainName.findPublicSuffix(InternetDomainName.java:173)
> at
> com.google.common.net.InternetDomainName.<init>(InternetDomainName.java:158)
> at com.google.common.net.InternetDomainName.from(InternetDomainName.java:213)
> [...]
> {noformat}
> ??EXACT field is expected to be present in
> com.google.thirdparty.publicsuffix.PublicSuffixPatterns??
> Having a quick look at storm-core-0.9.3-rc1.jar contents :
> * com.google.common is relocated to org.apache.storm.guava
> * com.google.thirdparty.publicsuffix is *not* relocated so it might conflict
> with user code (that's my case)
> Regards,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
