Github user clockfly commented on a diff in the pull request:

    https://github.com/apache/storm/pull/268#discussion_r19519682
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj ---
    @@ -378,9 +392,15 @@
     
             _ (refresh-connections nil)
             _ (refresh-storm-active worker nil)
    +
    +        receive-thread-shutdown (launch-receive-thread worker)
    +
    +        ;; make sure all messaging connections are ready for sending data, 
the netty messaging
    +        ;; client will drop the messages if client.send(msg) is called 
before the connection
    +        ;; is established.
    +        _ (wait-messaging-connections-to-be-ready worker)
      
    --- End diff --
    
    The wait here is to solve a corner case.
    
    When the topology boots up. Previsous approach will start spout 
immediately, which will use the IConnection layer before the IConnection is 
available.
    
    The wait-messaging-connections-to-be-ready is to ensure that the connection 
layer is ready before starting spout.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to