Github user clockfly commented on the pull request:

    https://github.com/apache/storm/pull/305#issuecomment-61631128
  
    
    @dashengju 
    
    When parent fails while child shell process is running correctly, should we 
call cleanup() to kill the suprocess first?
    
    This has two benefits:
    1. avoid zoombie sub process to exist
    2. Avoid blocking at sub process errorstream reading.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to