Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/298#issuecomment-61713139
  
    Just 2 cents.
    extrajars consists of jar, ~/.storm, <storm dir>/bin, which may not fit for 
linking dll or so (for JNI) which is already installed for other places.
    (Btw, is ~/.storm used for storing native library?)
    AFAIK we could link it without modifying storm, LD_LIBRARY_PATH (Linux) and 
PATH (Windows) so we already have option.
    Since I agree it's not sufficient to support both platforms (though it can 
fixed easily), I also think new path shouldn't in storm distribute directory. 
If we really need this, path should be fully flexible, not relative to storm 
dir. Because it can be harder for users to deploy their own library with Storm.
    (@caofangkun Did you think how you deploy your so file to Storm?)
    Regarding to PLATFORM distribution, it could be up to users to deploy their 
library which fit machine's architecture and OS.
    
    tl;dr. It seems to not convenient after applying PR, though current may be 
not convenient, but we can use OS environment to cover this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to