[
https://issues.apache.org/jira/browse/STORM-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196799#comment-14196799
]
ASF GitHub Bot commented on STORM-535:
--------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/298#issuecomment-61713139
Just 2 cents.
extrajars consists of jar, ~/.storm, <storm dir>/bin, which may not fit for
linking dll or so (for JNI) which is already installed for other places.
(Btw, is ~/.storm used for storing native library?)
AFAIK we could link it without modifying storm, LD_LIBRARY_PATH (Linux) and
PATH (Windows) so we already have option.
Since I agree it's not sufficient to support both platforms (though it can
fixed easily), I also think new path shouldn't in storm distribute directory.
If we really need this, path should be fully flexible, not relative to storm
dir. Because it can be harder for users to deploy their own library with Storm.
(@caofangkun Did you think how you deploy your so file to Storm?)
Regarding to PLATFORM distribution, it could be up to users to deploy their
library which fit machine's architecture and OS.
tl;dr. It seems to not convenient after applying PR, though current may be
not convenient, but we can use OS environment to cover this.
> setup 'java.library.path' for native-storm code if necessary
> ------------------------------------------------------------
>
> Key: STORM-535
> URL: https://issues.apache.org/jira/browse/STORM-535
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: caofangkun
> Priority: Minor
>
> JAVA_LIBRARY_PATH=${STORM_HOME}/lib/native/${JAVA_PLATFORM}
> eg:
> If run storm on amd64 , then will add following into JAVA_LIBRARY_PATH
> ${STORM_HOME}/lib/native/Linux-amd64-64/libsigar-amd64-linux.so
> If run storm on x86_64 , then will add following into JAVA_LIBRARY_PATH
> ${STORM_HOME}/lib/native/Linux-x86_64-64/libsigar-x86-linux.so
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
