[ 
https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198562#comment-14198562
 ] 

ASF GitHub Bot commented on STORM-492:
--------------------------------------

Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/279#issuecomment-61831975
  
    @clockfly  this patch doesn't work. running this mvn clean install 
-DSTORM_TEST_TIMEOUT_MS=30000
      (let [timeout (System/getProperty "STORM_TEST_TIMEOUT_MS")]
    the above code in testing.clj won't pick up the -D variable because 
STORM_TEST_TIMEOUT_MS is not a pom variable.
    As per the above reviews we asked for a change to System/getenv where users 
can export STORM_TEST_TIMEOUT_MS=10000 and the getenv will pick up but looks 
like this got merged in without those changes . Can you please revert this 
patch.
    @HeartSaVioR  Please update the PR with @ptgoetz suggestions. 


> Test timeout should be configurable
> -----------------------------------
>
>                 Key: STORM-492
>                 URL: https://issues.apache.org/jira/browse/STORM-492
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Devika Nair
>            Assignee: Jungtaek Lim
>              Labels: newbie
>             Fix For: 0.9.3-rc2
>
>
> Test timeout is hard coded to 5000ms in 
> https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/testing.clj.
>  Provide a way to override this value in order to handle longer running tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to