I find the source of the problem. The config value is a java boolean

And (not (Boolean. false)) == false
So the value is effectively ignored.
See last comment on the ticket at:
https://issues.apache.org/jira/browse/STORM-549

Can I just open a PR again the github repo with the fix for this?



On Thu, Nov 6, 2014 at 1:20 PM, Sean Allen <[email protected]>
wrote:

> Done.
>
> On Thu, Nov 6, 2014 at 1:01 PM, Derek Dagit <[email protected]>
> wrote:
>
>> Hm, I see the same thing.  Yes, please open a JIRA.
>> Thanks for reaching out about it,
>>  --
>> Derek
>>
>>
>>      On Thursday, November 6, 2014 11:11 AM, Sean Allen <
>> [email protected]> wrote:
>>
>>
>>  Sorry forgot to include another relevant bit of source:
>>
>> ➜  apache-storm-0.9.2-incubating ag "topology.enable.message.timeouts"
>> conf/defaults.yaml
>> 122:topology.enable.message.timeouts: true
>>
>> storm-core/src/jvm/backtype/storm/Config.java
>> 512:    public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
>> "topology.enable.message.timeouts";
>>
>> ➜  apache-storm-0.9.2-incubating ag TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS
>> storm-core/src/jvm/backtype/storm/Config.java
>> 512:    public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
>> "topology.enable.message.timeouts";
>> 513:    public static final Object TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS_SCHEMA
>> = Boolean.class;
>>
>> On Thu, Nov 6, 2014 at 12:02 PM, Sean Allen <[email protected]>
>> wrote:
>>
>> > Hi all,
>> >
>> > It would appear that "topology.enable.message.timeouts" settings isn't
>> > being used anymore.
>> > I discovered this when I used this following in my topology but has
>> > timeouts after 30 seconds:
>> >
>> >    config.put("topology.enable.message.timeouts", Boolean.FALSE)
>> >
>> > A search of the source revels it isn't being used. I assume this was in
>> > error? If yes, I can open a ticket in jira.
>> >
>> > ➜  apache-storm-0.9.2-incubating ag "topology.enable.message.timeouts"
>> > conf/defaults.yaml
>> > 122:topology.enable.message.timeouts: true
>> >
>> > storm-core/src/jvm/backtype/storm/Config.java
>> > 512:    public static final String TOPOLOGY_ENABLE_MESSAGE_TIMEOUTS =
>> > "topology.enable.message.timeouts";
>> >
>> > -Sean-
>> >
>>
>>
>>
>> --
>>
>> Ce n'est pas une signature
>>
>>
>>
>
>
>
> --
>
> Ce n'est pas une signature
>



-- 

Ce n'est pas une signature

Reply via email to