[ 
https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216283#comment-14216283
 ] 

ASF GitHub Bot commented on STORM-492:
--------------------------------------

Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/316#issuecomment-63486189
  
    Hello.
    To understand the reason, please reference STORM-492.
    Actually test time is affected to user machine rather than test complexity,
    so fixed timeout value is unusable.
    On 2014년 11월 18일 (화) at 오후 11:24 Ahmet DAL <[email protected]> wrote:
    
    > Custom test timeout with variable TEST-TIMEOUT-MS was being defined with
    > System Environment Variable. This cause a problem to define it on every
    > test simply. System property is now being used to define custom
    > TEST-TIMEOUT-MS variable value. This can be simply set before every test 
as
    >
    > System.setProperty("STORM_TEST_TIMEOUT_MS", "20000");
    > ------------------------------
    > You can merge this Pull Request by running
    >
    >   git pull https://github.com/javrasya/storm master
    >
    > Or view, comment on, or merge it at:
    >
    >   https://github.com/apache/storm/pull/316
    > Commit Summary
    >
    >    - Custom TEST-TIMEOUT-MS Definition Method Changed
    >
    > File Changes
    >
    >    - *M* storm-core/src/clj/backtype/storm/testing.clj
    >    <https://github.com/apache/storm/pull/316/files#diff-0> (2)
    >
    > Patch Links:
    >
    >    - https://github.com/apache/storm/pull/316.patch
    >    - https://github.com/apache/storm/pull/316.diff
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/storm/pull/316>.
    >


> Test timeout should be configurable
> -----------------------------------
>
>                 Key: STORM-492
>                 URL: https://issues.apache.org/jira/browse/STORM-492
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Devika Nair
>            Assignee: Jungtaek Lim
>              Labels: newbie
>             Fix For: 0.9.3-rc2
>
>
> Test timeout is hard coded to 5000ms in 
> https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/testing.clj.
>  Provide a way to override this value in order to handle longer running tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to