Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/296#discussion_r20535744
  
    --- Diff: storm-core/src/clj/backtype/storm/util.clj ---
    @@ -372,6 +372,13 @@
           (throw (RuntimeException. (str "Got unexpected process name: " 
name))))
         (first split)))
     
    +(defn exists-process?
    +   [process-id]  
    +   (if on-windows?
    +       (exec-command! ( str "tasklist /v /fi \"PID eq "  process-id + "\"" 
" | find /i \"" process-id "\""))
    +       (exists-file? (str "/proc/"  process-id))
    --- End diff --
    
    I would just change it to be ```ps -p``` instead of --pid.  BSD variants do 
not support the --pid, but -p I believe is POSIX.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to